Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combine the two getMatrixLayout definitions #1191

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Combine the two getMatrixLayout definitions #1191

merged 1 commit into from
Sep 23, 2024

Conversation

aurianer
Copy link
Collaborator

@aurianer aurianer commented Sep 19, 2024 •
edited
Loading

Reduces duplication. Fix #1190.

@aurianer aurianer self-assigned this Sep 19, 2024
@aurianer aurianer force-pushed the combine_get_matrix_layout branch 2 times, most recently from 64ed4d6 to 1ba8c14 Compare September 19, 2024 12:58
@aurianer
Copy link
Collaborator Author

cscs-ci run

@aurianer
Copy link
Collaborator Author

cscs-ci run

@aurianer aurianer marked this pull request as ready for review September 20, 2024 09:07
@aurianer
Copy link
Collaborator Author

In this PR since the element type of the vector is templated, there is no constraint on the device to be Device::GPU anymore. I would be fine with keeping it like this for simplicity but let me know if I should ask a check for this.

@aurianer
Copy link
Collaborator Author

In this PR since the element type of the vector is templated, there is no constraint on the device to be Device::GPU anymore. I would be fine with keeping it like this for simplicity but let me know if I should ask a check for this.

As discussed getMatrixLayout is both in the internal namespace and guarded with #if defined(DLAF_WITH_GPU. The only two instantiations of getMatrixLayout are also in a function which constrains the tile to be on GPU (see https://github.com/eth-cscs/DLA-Future/pull/1191/files#diff-8b55598c08934178848a057fc67db0ca4f0b77fc69f2cccf20dcec6301825261L166-L167). We agreed that there is no need of an extra check on the device.

@rasolca rasolca merged commit dbfb388 into eth-cscs:master Sep 23, 2024
5 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 23, 2024
@rasolca
Doc: Combine the two getMatrixLayout definitions (#1191)
2957adf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msimberg msimberg msimberg approved these changes

Assignees

@aurianer aurianer

Labels
None yet
Projects
DLA-F Planning
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Combine getMatrixLayout into one function
3 participants
@aurianer @msimberg @rasolca